alexbegg opened a new pull request #10637:
URL: https://github.com/apache/airflow/pull/10637


   Closes: #10350
   Replaces PR https://github.com/apache/airflow/pull/10556
   
   It has been reported that the last run's execution date was incorrectly 
showing for both the last run's link text as well as the "Start Date" in the 
(i) tooltip on the DAGs page. This was happening in the RBAC UI. For example, 
this was wrong, the "Start Date" was _not_ `2020-08-08T00:00:00+00:00`, that is 
the `execution_date `:
   ![Screen Shot 2020-08-28 at 11 42 09 
AM](https://user-images.githubusercontent.com/45696489/91604632-e4cd2c00-e923-11ea-8da5-55a2d101be94.png)
   
   This PR fixes it so it shows the _actual_ `start_date` for the "Start Date" 
tooltip instead of the `execution_date`, like it used to do in non-RBAC (FAB) 
UI:
   ![Screen Shot 2020-08-28 at 11 41 00 
AM](https://user-images.githubusercontent.com/45696489/91605066-b4d25880-e924-11ea-8454-2c78e83d3a72.png)
   
   Starting with the commit 
https://github.com/apache/airflow/commit/ba9c035a851bdabc9324a1fa3eb372b0422b784a
 which loads the latest_dagruns asynchronously the correct Start Date was lost. 
This PR replaces the correct Start Date.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to