alexbegg commented on a change in pull request #10637:
URL: https://github.com/apache/airflow/pull/10637#discussion_r482263524
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -369,14 +369,15 @@ <h2>DAGs</h2>
function lastDagRunsHandler(error, json) {
Review comment:
Well, I am not adding new functionality, just fixing a bug/regression. I
am just putting back a value lost when the values was changed to load
asynchronously. But it is a valid point as that function was added at that
point it was change to asynchronous.
This function appears to be named the same as the `/last_dagruns` endpoint
that returns json for these dates, which is in turn seems to be named after the
"Last Run" column this tooltip is in (I think). So the column is showing the
last run's execution date and the last run's start date. What name should it be
instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
