mik-laj commented on a change in pull request #10677:
URL: https://github.com/apache/airflow/pull/10677#discussion_r483282305
##########
File path: airflow/cli/cli_parser.py
##########
@@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):
func=lazy_load_command('airflow.cli.commands.dag_command.dag_list_dags'),
args=(ARG_SUBDIR, ARG_OUTPUT),
),
+ ActionCommand(
+ name='generate_kubernetes_pod_yaml',
+ help="Generate YAML files for all tasks in DAG",
+
func=lazy_load_command('airflow.cli.commands.dag_command.generate_pod_yaml'),
+ args=(ARG_SUBDIR, ARG_DAG_ID, ARG_OUTPUT_PATH, ARG_EXEC_DATE),
Review comment:
This is not necessary, but should we update the other commands as well?
Using CLI is very often based on habits, and I think it's worth making sure
that all commands have a similar style.
```
airflow dags test example_bash_operator 2019-01-01
airflow dags generate_kubernetes_pod_yaml example_bash_operator --exec-date
2019-01-01
```
I suspect these two commands may be used by the same people and follow two
different conventions. This is very confusing to the user. I am in favor of
making this argument optional, but it should be done in all commands, or none
of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
