[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

Thu, 03 Sep 2020 15:27:24 -0700 


mik-laj commented on a change in pull request #10677:
URL: https://github.com/apache/airflow/pull/10677#discussion_r483286372



##########
File path: airflow/cli/cli_parser.py
##########
@@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):
         
func=lazy_load_command('airflow.cli.commands.dag_command.dag_list_dags'),
         args=(ARG_SUBDIR, ARG_OUTPUT),
     ),
+    ActionCommand(
+        name='generate_kubernetes_pod_yaml',
+        help="Generate YAML files for all tasks in DAG",
+        
func=lazy_load_command('airflow.cli.commands.dag_command.generate_pod_yaml'),

Review comment:
       ```suggestion
           name='dump-pod-yaml',
           help="Generate YAML files with K8S Pod definitions.",
           description="Generate YAML files with Kubernetes Pod definitions for 
all tasks in DAG",
   ```
   This command name is too long. It doesn't look good in CLI.
   <img width="687" alt="Screenshot 2020-09-04 at 00 25 43" 
src="https://user-images.githubusercontent.com/12058428/92179595-440bce80-ee45-11ea-8f0b-ed578042e3c3.png";>
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to