kaxil commented on a change in pull request #10727:
URL: https://github.com/apache/airflow/pull/10727#discussion_r483769070
##########
File path: kubernetes_tests/test_kubernetes_pod_operator.py
##########
@@ -903,7 +904,6 @@ def test_on_kill(self,
self.assertEqual(pod.status.phase, "Running")
k.on_kill()
with self.assertRaises(ApiException):
- # pod should be deleted
- client.read_namespaced_pod(name=name, namespace=namespace)
+ pod = client.read_namespaced_pod(name=name, namespace=namespace)
Review comment:
Can we add a test that verifies that `termination_grace_period` is
passed correctly i.e. mocking `delete_namespaced_pod` and just doing
assert_called_with
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
