dimberman commented on a change in pull request #10727:
URL: https://github.com/apache/airflow/pull/10727#discussion_r483770449
##########
File path: kubernetes_tests/test_kubernetes_pod_operator.py
##########
@@ -903,7 +904,6 @@ def test_on_kill(self,
self.assertEqual(pod.status.phase, "Running")
k.on_kill()
with self.assertRaises(ApiException):
- # pod should be deleted
- client.read_namespaced_pod(name=name, namespace=namespace)
+ pod = client.read_namespaced_pod(name=name, namespace=namespace)
Review comment:
@kaxil the termination_grace_period is being passed because without
passing it this test would fail. read_namespaced_pod only returns an error when
the pod is fully deleted and this pod would take 20 seconds to delete without a
termination_grace_period.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
