feluelle commented on a change in pull request #10784:
URL: https://github.com/apache/airflow/pull/10784#discussion_r485396573
##########
File path: setup.py
##########
@@ -698,7 +699,7 @@ def is_package_excluded(package: str, exclusion_list:
List[str]):
'flask>=1.1.0, <2.0',
'flask-appbuilder>2.3.4,~=3.0',
'flask-caching>=1.3.3, <2.0.0',
- 'flask-login>=0.3, <1.0',
+ 'flask-login>=0.3, <0.5',
Review comment:
And here.
##########
File path: setup.py
##########
@@ -201,6 +201,7 @@ def write_version(filename: str = os.path.join(*[my_dir,
"airflow", "git_version
'celery~=4.4.2',
'flower>=0.7.3, <1.0',
'tornado>=4.2.0, <6.0', # Dep of flower. Pin to a version that works on
Py3.5.2
+ 'vine~=1.3', #
https://stackoverflow.com/questions/32757259/celery-no-module-named-five
Review comment:
I read about it in your slack thread but this should be a separate PR
imo.
##########
File path: setup.py
##########
@@ -247,7 +248,7 @@ def write_version(filename: str = os.path.join(*[my_dir,
"airflow", "git_version
'facebook-business>=6.0.2',
]
flask_oauth = [
- 'Flask-OAuthlib>=0.9.1',
+ 'Flask-OAuthlib>=0.9.1,<0.9.6', # Flask OAuthLib 0.9.6 requires
Flask-Login 0.5.0 - breaks FAB
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
