potiuk commented on a change in pull request #10784:
URL: https://github.com/apache/airflow/pull/10784#discussion_r488679641
##########
File path: Dockerfile.ci
##########
@@ -256,7 +256,7 @@ ENV
UPGRADE_TO_LATEST_CONSTRAINTS=${UPGRADE_TO_LATEST_CONSTRAINTS}
# But in cron job we will install latest versions matching setup.py to see if
there is no breaking change
# and push the constraints if everything is successful
RUN \
- if [[ "${UPGRADE_TO_LATEST_CONSTRAINTS}" == "true" ]]; then \
+ if [[ "${UPGRADE_TO_LATEST_CONSTRAINTS}" != "false" ]]; then \
Review comment:
Nope. Only when the buld runs in master. All the PRs have
"UPGRADE_TO_LATEST_CONSTRAINTS" set to "false" but all the "master" push-es
have the UPGRADE_TO_LATEST_CONSTRAINTS set to "COMMIT_SHA" so that every new
master push will automatically invalidate this line in Dockerfile (but only
master push, not PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
