[ 
https://issues.apache.org/jira/browse/AIRFLOW-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223492#comment-16223492
 ] 

ASF subversion and git services commented on AIRFLOW-1734:
----------------------------------------------------------

Commit 1d531555ecd594ee7ec2c5d3fc87f8d4bcc2c27e in incubator-airflow's branch 
refs/heads/master from [~ahaidrey]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=1d53155 ]

[AIRFLOW-1734][Airflow 1734] Sqoop hook/operator enhancements

Closes #2703 from Acehaidrey/sqoop_contrib_fixes


> Sqoop Operator contains logic errors & needs options to pass more sqoop 
> options
> -------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-1734
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1734
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib
>            Reporter: Ace Haidrey
>            Assignee: Ace Haidrey
>              Labels: patch
>             Fix For: 1.9.0
>
>
> After taking a look at the Sqoop Operator I have found a number of errors 
> with it. I will describe them in depth on the PR I will make, but it includes 
> assign wrong parameters, not hiding the users raw password in the logs 
> (though a method to do that had been created in the hook, wrong if 
> conditions, and the inability to add other sqoop options that would make 
> sense to have the option to pass those.
> I have made some remarks in past commits about it too in the case I'm 
> misinterpreting but regardless there are definitely errors.
> https://github.com/apache/incubator-airflow/pull/2177#pullrequestreview-70046796
> Here is my PR with change by change explanation:
> https://github.com/apache/incubator-airflow/pull/2703/files#diff-8e77f042c2e060bbfd60828431a91e9bL131



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to