[
https://issues.apache.org/jira/browse/AIRFLOW-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588882#comment-16588882
]
Chengzhi Zhao commented on AIRFLOW-2929:
----------------------------------------
Update:
After exploring API, I noticed we already have another class pool under
experimental and local cli is using it
[https://github.com/apache/incubator-airflow/blob/master/airflow/api/common/experimental/pool.py
https://github.com/apache/incubator-airflow/blob/master/airflow/api/client/local_client.py#L21
|https://github.com/apache/incubator-airflow/blob/master/airflow/api/common/experimental/pool.py]
Not sure the initial intention here why it was experimental first, I was
wondering if this is still a validate call to move the functionalities back to
models.py to avoid code in multiple places. Please suggest.
> Add get and set for pool class in models.py
> -------------------------------------------
>
> Key: AIRFLOW-2929
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2929
> Project: Apache Airflow
> Issue Type: Improvement
> Components: models
> Reporter: Chengzhi Zhao
> Assignee: Chengzhi Zhao
> Priority: Minor
>
> Currently Pool class in models.py doesn't have get and set method, I suggest
> we add those methods to make them similar as Variable/Connection class, it
> will also be easier to have cli get more descriptive response as discussed
> here
> https://github.com/apache/incubator-airflow/pull/3730#discussion_r210185544
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
