[
https://issues.apache.org/jira/browse/AIRFLOW-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606491#comment-16606491
]
ASF GitHub Bot commented on AIRFLOW-2929:
-----------------------------------------
ChengzhiZhao opened a new pull request #3858: [AIRFLOW-2929] Add get and set
for pool class in models
URL: https://github.com/apache/incubator-airflow/pull/3858
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Currently Pool class in models.py doesn't have get and set method, I suggest
we add those methods to make them similar as Variable/Connection class, it will
also be easier to have cli get more descriptive response as discussed
[here](https://github.com/apache/incubator-airflow/pull/3730#discussion_r210185544)
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
This PR is code refactoring so unit tests have been already includes.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add get and set for pool class in models.py
> -------------------------------------------
>
> Key: AIRFLOW-2929
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2929
> Project: Apache Airflow
> Issue Type: Improvement
> Components: models
> Reporter: Chengzhi Zhao
> Assignee: Chengzhi Zhao
> Priority: Minor
>
> Currently Pool class in models.py doesn't have get and set method, I suggest
> we add those methods to make them similar as Variable/Connection class, it
> will also be easier to have cli get more descriptive response as discussed
> here
> https://github.com/apache/incubator-airflow/pull/3730#discussion_r210185544
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
