ashb commented on a change in pull request #4014: [AIRFLOW-3168] add
healthcheck for mysql setup in CI
URL: https://github.com/apache/incubator-airflow/pull/4014#discussion_r223990038
##########
File path: scripts/ci/3-setup-databases.sh
##########
@@ -20,4 +20,9 @@ set -exuo pipefail
MYSQL_HOST=mysql
+# make sure mysql is done setting up
+while ! mysqladmin ping -h ${MYSQL_HOST} -u root --silent; do
+ sleep 1
+done
Review comment:
One reason might be to test the MySql operator etc, but we could probably
just set that to skip those tests in that test matrix.
If it's more work to do (i.e. if you haven't done it yet, or the tests don't
pass) then you could make that a separate PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
