ashb commented on a change in pull request #4014: [AIRFLOW-3168] add 
healthcheck for mysql setup in CI
URL: https://github.com/apache/incubator-airflow/pull/4014#discussion_r224054655
 
 

 ##########
 File path: tests/executors/test_celery_executor.py
 ##########
 @@ -26,11 +26,16 @@
 from airflow.executors.celery_executor import CELERY_FETCH_ERR_MSG_HEADER
 from airflow.utils.state import State
 
+from airflow import configuration
+configuration.load_test_config()
+
 # leave this it is used by the test worker
 import celery.contrib.testing.tasks  # noqa: F401
 
 
 class CeleryExecutorTest(unittest.TestCase):
+    @unittest.skipUnless('mysql' in configuration.conf.get('core', 
'sql_alchemy_conn'),
+                         "currently celery configs on travis are mysql")
 
 Review comment:
   I think rather than skipping this we could set this in tox.ini:
   
   ```
      backend_postgres: 
AIRFLOW__CELERY__RESULT_BACKEND=db+postgresql://postgres:airflow@postgres/airflow
 
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to