XD-DENG commented on a change in pull request #3981: [AIRFLOW-3133] Implement
xcom_push flag for contrib's operators
URL: https://github.com/apache/incubator-airflow/pull/3981#discussion_r224664461
##########
File path: airflow/contrib/operators/bigquery_get_data.py
##########
@@ -78,6 +80,7 @@ def __init__(self,
selected_fields=None,
bigquery_conn_id='bigquery_default',
delegate_to=None,
+ do_xcom_push=True,
Review comment:
Personally I think `False` is making more sense. Was this discussed by other
folks?
In addition, if that's the case and we go for `True`, other changes would be
needed, for example, the default value of `xcom_push` in
[`BashOperator`](https://github.com/apache/incubator-airflow/blob/master/airflow/operators/bash_operator.py)
is `False` currently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
