XD-DENG commented on a change in pull request #3981: [AIRFLOW-3133] Implement 
xcom_push flag for contrib's operators
URL: https://github.com/apache/incubator-airflow/pull/3981#discussion_r224664921
 
 

 ##########
 File path: airflow/contrib/operators/bigquery_get_data.py
 ##########
 @@ -78,6 +80,7 @@ def __init__(self,
                  selected_fields=None,
                  bigquery_conn_id='bigquery_default',
                  delegate_to=None,
+                 do_xcom_push=True,
 
 Review comment:
   Did another quick check: seems default value of most existing 
`xcom_push`/`do_xcom_push` arguments are `False`. We should make all of them 
consistent no matter we decide to use `True` or `False`.
   
   BTW, now I understand why @itscaro put `do_xcom_push` as the variable name 
since it is used in some of the operators. This may cause confusion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to