itscaro commented on a change in pull request #3981: [AIRFLOW-3133] Implement 
xcom_push flag for contrib's operators
URL: https://github.com/apache/incubator-airflow/pull/3981#discussion_r225113656
 
 

 ##########
 File path: airflow/contrib/operators/bigquery_get_data.py
 ##########
 @@ -78,6 +80,7 @@ def __init__(self,
                  selected_fields=None,
                  bigquery_conn_id='bigquery_default',
                  delegate_to=None,
+                 do_xcom_push=True,
 
 Review comment:
   The choice of default value `True` was intended for non breaking 
compatibility, as suggested by @ashb. But I agree that `False` is more coherent 
with core operators
   
   https://github.com/apache/incubator-airflow/pull/3981#issuecomment-425855530

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to