itscaro commented on a change in pull request #3981: [AIRFLOW-3133] Implement
xcom_push flag for contrib's operators
URL: https://github.com/apache/incubator-airflow/pull/3981#discussion_r225114997
##########
File path: airflow/contrib/operators/gcs_to_bq.py
##########
@@ -248,7 +252,7 @@ def execute(self, context):
time_partitioning=self.time_partitioning,
cluster_fields=self.cluster_fields)
- if self.max_id_key:
+ if self.do_xcom_push and self.max_id_key:
Review comment:
I wondered too but I decided to add `xcom_push` flag so that the
`max_id_key` is not an exceptional flag to enable xcom feature. The best might
be renaming `max_id_key` to `xcom_push` flag & add documenation to explain what
is pushed to xcom when the feature is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
