ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos… URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236356747
########## File path: airflow/security/kerberos.py ########## @@ -27,19 +27,21 @@ log = LoggingMixin().log -def renew_from_kt(): +def renew_from_kt(args=None): Review comment: I think rather than pass the whole args dict in here it would be better to pass the two we specifically want (`principal`, and `keytab`) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
