ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos
cli args keytab and principal to kerberos…
URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236793244
##########
File path: airflow/security/kerberos.py
##########
@@ -80,7 +82,7 @@ def perform_krb181_workaround():
ret = subprocess.call(cmdv, close_fds=True)
if ret != 0:
- principal = "%s/%s" % (
+ principal = args.principal or "%s/%s" % (
Review comment:
This is a change in behaviour.
Previously:
```
principal == "the-actual-principal/my-fqdn"
```
After if I specify the arg:
```
principal == "the-actual-principal"
```
i.e. if arg.principal is provided the format is never called, and I think it
should be?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
