XD-DENG commented on a change in pull request #4309: [AIRFLOW-3504]
Extend/refine the functionality of "/health" endpoint
URL: https://github.com/apache/incubator-airflow/pull/4309#discussion_r242775695
##########
File path: airflow/www_rbac/views.py
##########
@@ -146,6 +146,29 @@ def render(self, template, **context):
class Airflow(AirflowBaseView):
+ @expose('/health')
Review comment:
Thanks @feng-tao for the review!
The current implementation is not requiring any logging-in to access
`/health` endpoint. But of course it only returns a very "safe" response "`The
server is healthy!`" (which is not useful/accurate).
For this PR, I would still like to suggest not require admin or logging-in
to access this endpoint. This is just like the status page of GitHub. Everyone
should be able access it without any logging-in. But on the other hand, we do
need to be careful of what to expose via this endpoint. This was partially
covered in my last reply comment to Kaxil.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
