zhoujinsong commented on code in PR #2818: URL: https://github.com/apache/amoro/pull/2818#discussion_r1594875167
########## docker/README.md: ########## @@ -24,18 +24,15 @@ You can control which image is built by the follow parameters : - amoro - optimizer-flink - optimizer-spark -- quickdemo -- namenode -- datanode e.g. ```shell ./build.sh amoro ``` -- NOTICE: The amoro image, quickdemo image and optimizer-flink image required the project had been packaged. -so run `mvn package -pl '!trino'` before build amoro, quickdemo or optimizer-flink image. +- NOTICE: The amoro image, amoro-spark-optimizer image and amoro-flink-optimizer image required the project had been packaged. +so run `mvn package -pl '!trino'` before build amoro, amoro-spark-optimizer or amoro-flink-optimizer image. Review Comment: ```suggestion So run `mvn package -pl '!amoro-mixed-fomrat/amoro-mixed-format-trino'` before building amoro, amoro-spark-optimizer, or amoro-flink-optimizer image. ``` ########## docker/build.sh: ########## @@ -44,23 +42,18 @@ Usage: $0 [options] [image] Build for Amoro demo docker images. Images: - quickdemo Build Amoro QuickStart Image, for run flink ingestion job in quick-demo http://amoro.apache.org/quick-demo/ - namenode Build a hadoop namenode container for quick start demo. - datanode Build a hadoop datanode container for quick start demo. optimizer-flink Build official Amoro optimizer deployed with flink engine for production environments. Review Comment: How about changing the name to `amoro-flink-optimizer`/`amoro-spark-optimizer` here? ########## charts/amoro/values.yaml: ########## @@ -254,7 +254,7 @@ optimizer: properties: namespace: "default" kube-config-path: "～/.kube/config" - image: "arctic163/amoro:0.6" + image: "apache/amoro:0.6" Review Comment: I'm concerned about whether specifying version 0.6 here is appropriate. ########## amoro-ams/dist/src/main/arctic-bin/conf/config.yaml: ########## @@ -142,7 +142,7 @@ containers: # container-impl: com.netease.arctic.server.manager.KubernetesOptimizerContainer # properties: # kube-config-path: ～/.kube/config -# image: arctic163/amoro:0.6 +# image: apache/amoro:0.6 Review Comment: Maybe replace `0.6` with `{version}`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
