zhoujinsong commented on code in PR #2818: URL: https://github.com/apache/amoro/pull/2818#discussion_r1594878485
########## docker/demo-cluster.sh: ########## @@ -1,186 +0,0 @@ -#!/usr/bin/env bash -# -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# * -# http://www.apache.org/licenses/LICENSE-2.0 -# * -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - - -# default to use the last built image when no specified tag given -AMORO_TAG=latest - - -CURRENT_DIR="$( cd "$(dirname "$0")" ; pwd -P )" - - -DOCKER_COMPOSE="${CURRENT_DIR}/docker-compose.yml" -HADOOP_CONF="${CURRENT_DIR}/hadoop-config" -VOLUMES_DIR="${CURRENT_DIR}/volumes" - -function usage() { - cat <<EOF -Usage: $0 [options] [command] -Build for Amoro demo docker images. - -Commands: - start Setup demo cluster - stop Stop demo cluster and remove containers, volume data will be kept. - clean clean volume data. - -Options: - -v --version Setup Amoro image version. default is ${AMORO_TAG} - -EOF -} Review Comment: I am not sure if we still need a shell script to create the docker-compose file or if just a compose example file is okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
