XBaith commented on code in PR #2824:
URL: https://github.com/apache/amoro/pull/2824#discussion_r1597331897
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/terminal/TerminalManager.java:
##########
@@ -121,17 +124,24 @@ public String executeScript(String terminalId, String
catalog, String script) {
TerminalSessionFactory.SessionConfigOptions.catalogProperty(catalog,
key), value);
}
- TerminalSessionContext context;
synchronized (sessionMapLock) {
- sessionMap.computeIfAbsent(
+ sessionMap.compute(
sessionId,
- id ->
- new TerminalSessionContext(
- id, metaStore, executionPool, sessionFactory,
configuration));
-
- context = sessionMap.get(sessionId);
+ (id, ctx) -> {
Review Comment:
Yes, because I found that session configuration was not update after
changing server catalog configurations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
