zhoujinsong commented on code in PR #2824:
URL: https://github.com/apache/amoro/pull/2824#discussion_r1597331981
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/terminal/TerminalManager.java:
##########
@@ -370,7 +380,16 @@ private void applyClientProperties(CatalogMeta
catalogMeta) {
catalogMeta.putToCatalogProperties(
CatalogMetaProperties.KEY_WAREHOUSE, catalogMeta.getCatalogName());
} else if
(!catalogMeta.getCatalogProperties().containsKey(CatalogProperties.CATALOG_IMPL))
{
- catalogMeta.putToCatalogProperties("type", catalogType);
+ if (Sets.newHashSet(
Review Comment:
According to the code here, If the `catalog-impl` property exists, we will
skip to set the type, so it will be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
