zhoujinsong commented on code in PR #2899:
URL: https://github.com/apache/amoro/pull/2899#discussion_r1625719953
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/utils/DesensitizationUtil.java:
##########
@@ -22,11 +22,26 @@
public class DesensitizationUtil {
public static String COMMON_SECRET_FORMAT = "********";
+ private static final String[] SENSITIVE_CONF_KEYWORDS = {"secret", "token",
"password"};
Review Comment:
I am not sure if we should desensitize all properties containing the
keywords above.
Or we may better define specific properties we should desensitize on and
open terminal configuration to allow user add more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
