zhoujinsong commented on code in PR #2899:
URL: https://github.com/apache/amoro/pull/2899#discussion_r1629409586


##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/terminal/TerminalSessionContext.java:
##########
@@ -48,6 +52,8 @@ public class TerminalSessionContext {
   private volatile ExecutionTask task = null;
   private final TerminalSessionFactory factory;
   private final Configurations sessionConfiguration;
+
+  private final List sensitiveConfKeys;

Review Comment:
   ```suggestion
     private final List<String> sensitiveConfKeys;
   ```



##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/terminal/local/LocalSessionFactory.java:
##########
@@ -50,10 +54,16 @@ public class LocalSessionFactory implements 
TerminalSessionFactory {
 
   SparkSession context = null;
   Configurations conf;
+  List sensitiveConfKeys;

Review Comment:
   ```suggestion
     List<String> sensitiveConfKeys;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to