Aireed opened a new pull request, #3300:
URL: https://github.com/apache/amoro/pull/3300
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in
https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title,
e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related
issue
-->
Close #1865.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
- Front-end:
- Configure by adding rules in the properties of optimize-group with key
'match.rules'
- Backend:
- 1. When creating a group, rule conflict detection will be performed.
And traverse the table corresponding to the catalog default value of the
current optimize-group to see if it matches the current rule and assign the
value.
- 2. When updating the optimize-group rules, rule conflict detection will
be performed.
- 1. First, the table under the current rule will be judged. If the
rule no longer matches after the rule is changed, the default group of the
catalog to which the table belongs will be used.
- 2. Traverse the table corresponding to the catalog default value of
the current optimize-group to see if it matches the current rule and assign the
value.
- 3. when deleting the group
- 1. Configure the tables under the group to the default group of the
catalog to which they belong.
When the group of the above table is changed, the tableConfigureChange
responsibility chain call of the table will be triggered.
- 4. When synchronizing the external catalog, the group will be
automatically matched according to regular rules.
- 5. TableRuntimeRefreshExecutor no longer pays attention to
optimize-group when refreshing.
- Special note
We support manually adding the table name to the rules of a group, which is
equivalent to the original manual configuration of the group. Because in our
practice, there are some situations that require manual specification.
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs /
not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
