Aireed commented on code in PR #3300:
URL: https://github.com/apache/amoro/pull/3300#discussion_r1821733946
##########
amoro-common/src/main/java/org/apache/amoro/ServerTableIdentifier.java:
##########
@@ -123,6 +123,10 @@ public String toString() {
return String.format("%s.%s.%s(tableId=%d)", catalog, database, tableName,
id);
}
+ public String getTableFullName() {
Review Comment:
> Is this method nessessary? How about invoke `getIdentifier().toString()`
to get full name?
`getIdentifier().toString()` returns `TableIdentifier[catalog.db.table]`, So
it's not suitable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
