zhoujinsong commented on code in PR #3296:
URL: https://github.com/apache/amoro/pull/3296#discussion_r1827150491
##########
amoro-ams/pom.xml:
##########
@@ -408,6 +409,66 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>io.swagger.core.v3</groupId>
+ <artifactId>swagger-annotations</artifactId>
+ <version>2.2.10</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.swagger.core.v3</groupId>
+ <artifactId>swagger-jaxrs2</artifactId>
+ <version>2.2.10</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.swagger.core.v3</groupId>
+ <artifactId>swagger-integration</artifactId>
+ <version>2.2.10</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.swagger.core.v3</groupId>
+ <artifactId>swagger-models</artifactId>
+ <version>2.2.10</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.swagger.parser.v3</groupId>
+ <artifactId>swagger-parser-v3</artifactId>
+ <version>2.1.14</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.webjars</groupId>
+ <artifactId>swagger-ui</artifactId>
+ <version>4.10.3</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.javalin</groupId>
+ <artifactId>javalin-openapi</artifactId>
+ <version>4.1.1</version>
+ </dependency>
+
+ <dependency>
Review Comment:
We already had httpclient:5.2 and httpcore:5.2 dependencies in runtime
scope, do we still need this?
##########
amoro-ams/pom.xml:
##########
@@ -35,6 +35,7 @@
<url>https://amoro.apache.org</url>
<properties>
+ <skip-generate-sdk>false</skip-generate-sdk>
Review Comment:
IMO, we should not generate the SDK by default as it is not required for
everyone.
But the doc is necessary for the dashboard.
So we may need to separate the properties for SDK and DOC.
##########
amoro-ams/pom.xml:
##########
@@ -408,6 +409,66 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>io.swagger.core.v3</groupId>
+ <artifactId>swagger-annotations</artifactId>
+ <version>2.2.10</version>
+ </dependency>
+
+ <dependency>
Review Comment:
Do we need the dependency by default?
Or should we separate them for the doc and the SDK?
##########
amoro-ams/pom.xml:
##########
@@ -408,6 +409,66 @@
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Yes, we may define the versions in properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
