zhoujinsong commented on code in PR #3296:
URL: https://github.com/apache/amoro/pull/3296#discussion_r1856505889
##########
amoro-ams/pom.xml:
##########
@@ -503,6 +517,69 @@
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
Review Comment:
How about putting this plugin with the profile too?
##########
amoro-ams/pom.xml:
##########
@@ -408,6 +410,18 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.webjars</groupId>
+ <artifactId>swagger-ui</artifactId>
+ <version>5.17.14</version>
+ </dependency>
+
+ <dependency>
Review Comment:
How about putting this dependency together with the profile to avoid adding
this dependency without the profile enable?
##########
amoro-ams/pom.xml:
##########
@@ -408,6 +410,18 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.webjars</groupId>
+ <artifactId>swagger-ui</artifactId>
+ <version>5.17.14</version>
Review Comment:
Maybe we should define a property to store this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
