zhongqishang commented on code in PR #3338:
URL: https://github.com/apache/amoro/pull/3338#discussion_r1851597993
##########
amoro-format-iceberg/src/main/java/org/apache/amoro/utils/TableFileUtil.java:
##########
@@ -199,6 +200,11 @@ public static String optimizingPosDeleteFileName(String
dataFileName, String suf
}
public static boolean isOptimizingPosDeleteFile(String dataFilePath, String
posDeleteFilePath) {
+ FileFormat fileFormat = FileFormat.fromFileName(dataFilePath);
+ if (fileFormat != null) {
+ dataFilePath =
+ dataFilePath.substring(0, dataFilePath.length() -
fileFormat.name().length() - 1);
Review Comment:
Good idea, but the FileFomrat is iceberg class, i will add the function in
class `org.apache.amoro.utils.TableFileUtil`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
