zhoujinsong commented on code in PR #3338:
URL: https://github.com/apache/amoro/pull/3338#discussion_r1853397863
##########
amoro-format-iceberg/src/main/java/org/apache/amoro/utils/TableFileUtil.java:
##########
@@ -199,7 +217,9 @@ public static String optimizingPosDeleteFileName(String
dataFileName, String suf
}
public static boolean isOptimizingPosDeleteFile(String dataFilePath, String
posDeleteFilePath) {
- return getFileName(posDeleteFilePath)
- .startsWith(String.format("%s-%s", getFileName(dataFilePath),
POS_DELETE_FILE_IDENTIFIER));
+ return getFileNameWithoutExt(posDeleteFilePath)
Review Comment:
We may skip truncating the extent for the position delete file path here to
reduce some cost as we determine by `startsWith`, HDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
