(amoro) branch master updated: [Improvement]: Improved test OptimizingStatusTest.testOptimizingStatusCodeValue to use parameterized unit testing (#3511)

[jinsongzhou]

This is an automated email from the ASF dual-hosted git repository.

jinsongzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/amoro.git


The following commit(s) were added to refs/heads/master by this push:
     new 98580590b [Improvement]: Improved test 
OptimizingStatusTest.testOptimizingStatusCodeValue to use parameterized unit 
testing (#3511)
98580590b is described below

commit 98580590b0fe5cf429f529b8c0cebc4937afc534
Author: Monil <16ucs...@lnmiit.ac.in>
AuthorDate: Sun Apr 13 21:10:23 2025 -0700

    [Improvement]: Improved test 
OptimizingStatusTest.testOptimizingStatusCodeValue to use parameterized unit 
testing (#3511)
    
    retrofitted OptimizingStatusTest.testOptimizingStatusCodeValue to 
parameterized
---
 .../server/optimizing/OptimizingStatusTest.java    | 25 +++++++++++++++-------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git 
a/amoro-ams/src/test/java/org/apache/amoro/server/optimizing/OptimizingStatusTest.java
 
b/amoro-ams/src/test/java/org/apache/amoro/server/optimizing/OptimizingStatusTest.java
index 2e0a041ef..f75f91fff 100644
--- 
a/amoro-ams/src/test/java/org/apache/amoro/server/optimizing/OptimizingStatusTest.java
+++ 
b/amoro-ams/src/test/java/org/apache/amoro/server/optimizing/OptimizingStatusTest.java
@@ -29,16 +29,25 @@ import java.util.stream.Stream;
 
 public class OptimizingStatusTest {
   @Test
-  public void testOptimizingStatusCodeValue() {
+  public void testNumberOfOptimizingStatuses() {
     assertEquals(7, OptimizingStatus.values().length);
+  }
 
-    assertEquals(OptimizingStatus.FULL_OPTIMIZING, 
OptimizingStatus.ofCode(100));
-    assertEquals(OptimizingStatus.MAJOR_OPTIMIZING, 
OptimizingStatus.ofCode(200));
-    assertEquals(OptimizingStatus.MINOR_OPTIMIZING, 
OptimizingStatus.ofCode(300));
-    assertEquals(OptimizingStatus.COMMITTING, OptimizingStatus.ofCode(400));
-    assertEquals(OptimizingStatus.PLANNING, OptimizingStatus.ofCode(500));
-    assertEquals(OptimizingStatus.PENDING, OptimizingStatus.ofCode(600));
-    assertEquals(OptimizingStatus.IDLE, OptimizingStatus.ofCode(700));
+  static Stream<Arguments> codeToStatusProvider() {
+    return Stream.of(
+        Arguments.of(100, OptimizingStatus.FULL_OPTIMIZING),
+        Arguments.of(200, OptimizingStatus.MAJOR_OPTIMIZING),
+        Arguments.of(300, OptimizingStatus.MINOR_OPTIMIZING),
+        Arguments.of(400, OptimizingStatus.COMMITTING),
+        Arguments.of(500, OptimizingStatus.PLANNING),
+        Arguments.of(600, OptimizingStatus.PENDING),
+        Arguments.of(700, OptimizingStatus.IDLE));
+  }
+
+  @ParameterizedTest
+  @MethodSource("codeToStatusProvider")
+  public void testOptimizingStatusCodeValue(int code, OptimizingStatus 
expectedStatus) {
+    assertEquals(expectedStatus, OptimizingStatus.ofCode(code));
   }
 
   static Stream<Arguments> displayValueToStatusProvider() {