This is an automated email from the ASF dual-hosted git repository.
jinsongzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/amoro.git
The following commit(s) were added to refs/heads/master by this push:
new f35c449e7 [Improvement]: Refactored MemorySizeTest.testParseBytes to
Parameterized Test (#3510)
f35c449e7 is described below
commit f35c449e7372f1c20e2f2a343fd6be97d056495d
Author: Monil <[email protected]>
AuthorDate: Sun Apr 13 21:11:06 2025 -0700
[Improvement]: Refactored MemorySizeTest.testParseBytes to Parameterized
Test (#3510)
* converted testParseBytes to parameterized
* fixed spotless erros
---
.../java/org/apache/amoro/utils/MemorySizeTest.java | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git
a/amoro-common/src/test/java/org/apache/amoro/utils/MemorySizeTest.java
b/amoro-common/src/test/java/org/apache/amoro/utils/MemorySizeTest.java
index 90720bc38..f65454e81 100644
--- a/amoro-common/src/test/java/org/apache/amoro/utils/MemorySizeTest.java
+++ b/amoro-common/src/test/java/org/apache/amoro/utils/MemorySizeTest.java
@@ -73,13 +73,16 @@ public class MemorySizeTest {
new MemorySize(-1);
}
- @Test
- public void testParseBytes() {
- assertEquals(1234, MemorySize.parseBytes("1234"));
- assertEquals(1234, MemorySize.parseBytes("1234b"));
- assertEquals(1234, MemorySize.parseBytes("1234 b"));
- assertEquals(1234, MemorySize.parseBytes("1234bytes"));
- assertEquals(1234, MemorySize.parseBytes("1234 bytes"));
+ @ParameterizedTest
+ @CsvSource({
+ "'1234', 1234",
+ "'1234b', 1234",
+ "'1234 b', 1234",
+ "'1234bytes', 1234",
+ "'1234 bytes', 1234"
+ })
+ public void testParseBytes(String input, long expected) {
+ assertEquals(expected, MemorySize.parseBytes(input));
}
@ParameterizedTest