zhoujinsong commented on code in PR #3557:
URL: https://github.com/apache/amoro/pull/3557#discussion_r2103731561
##########
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java:
##########
@@ -113,6 +113,7 @@ public void onTableDropped(InternalCatalog catalog,
ServerTableIdentifier identi
"Error occurred while removing tableRuntime of table {}",
identifier.getId(),
e);
+ throw e;
Review Comment:
Hi, thanks for the detailed description.
On the contrary, I think we should not throw the exception in this
situation. When the table metadata is removed from the persistent, the table is
already removed. The following operations, like removing table runtime and
purging files in the storage, are allowed to fail and should be executed again
if they fail.
So, removing the table runtime operation better not prevent the purging file
operation. HDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
