Jzjsnow commented on code in PR #3557:
URL: https://github.com/apache/amoro/pull/3557#discussion_r2126304860
##########
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java:
##########
@@ -113,6 +113,7 @@ public void onTableDropped(InternalCatalog catalog,
ServerTableIdentifier identi
"Error occurred while removing tableRuntime of table {}",
identifier.getId(),
e);
+ throw e;
Review Comment:
Got it, I agree with your perspective. The table metadata is the critical
part; once it's removed, the table is essentially deleted. Dropping the table
runtime is a secondary operations that can be retried. Preventing the table
dropping operation due to a temporary failure in dropping the table runtime
could lead to orphaned data, which is worse than an eventual consistency issue
with the table runtime.
I've updated the code in DefaultTableService#onTableDropped to log the
exception instead of throwing it when dropping the internal table. For external
tables, though, the exception in DefaultTableService#disposeTable remains
thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
