ygjia commented on PR #3700: URL: https://github.com/apache/amoro/pull/3700#issuecomment-3205147612
> Hi, you may need to change the access modifier of `validate` method in https://github.com/apache/amoro/blob/master/amoro-format-mixed/amoro-mixed-flink/amoro-mixed-flink-common-iceberg-bridge/src/main/java/org/apache/iceberg/flink/source/ScanContext.java#L236 to `package-private`, according the change in Iceberg repo:https://github.com/apache/iceberg/blob/apache-iceberg-1.6.1/flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java#L134 Thanks for the review! The [Iceberg-ScanContext](https://github.com/apache/iceberg/blob/1.6.x/flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java) in Iceberg 1.6.1 has changed compared to [Amoro-ScanContext](https://github.com/apache/amoro/blob/96de6456f19039a50b66ac3882805dd6170e2368/amoro-format-mixed/amoro-mixed-flink/amoro-mixed-flink-common-iceberg-bridge/src/main/java/org/apache/iceberg/flink/source/ScanContext.java#L42), which caused several UTs to fail before. > org.apache.amoro.flink.table.TestUnkeyed > org.apache.amoro.flink.read.TestFlinkSource > org.apache.amoro.flink.table.TestLookupSecondary > org.apache.amoro.flink.table.TestUnkeyedOverwrite I have aligned it with Iceberg 1.6.1, and above UTs passed locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
