ygjia commented on code in PR #3700:
URL: https://github.com/apache/amoro/pull/3700#discussion_r2300020907
##########
amoro-format-mixed/amoro-mixed-flink/amoro-mixed-flink-common/src/main/java/org/apache/amoro/flink/read/hybrid/split/TemporalJoinSplits.java:
##########
@@ -44,7 +44,7 @@ public class TemporalJoinSplits implements Serializable {
public static final long serialVersionUID = 1L;
public static final Logger LOGGER =
LoggerFactory.getLogger(TemporalJoinSplits.class);
- private final MetricGroup metricGroup;
+ private final transient MetricGroup metricGroup;
Review Comment:
In Flink 1.18, metricGroup was added to SourceCoordinatorContext ([PR
#21952](https://github.com/apache/flink/pull/21952/files#diff-9144631bff9092280da424a52db7a60d2e0f47e82b0c55ccbdc93ac29614d75c)).
This change causes a serialization issue in
MixedFormatSourceEnumStateSerializer.
To resolve the problem, we mark the corresponding field as transient.
org.apache.amoro.flink.read.TestMixedFormatSource#testDimTaskManagerFailover
> Caused by: java.io.NotSerializableException:
org.apache.flink.runtime.metrics.groups.InternalSplitEnumeratorMetricGroup
at
java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1175) ~[?:?]
at
java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1543)
~[?:?]
at
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1500) ~[?:?]
at
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1423)
~[?:?]
at
java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1169) ~[?:?]
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:345)
~[?:?]
at
org.apache.flink.util.InstantiationUtil.serializeObject(InstantiationUtil.java:553)
~[flink-core-1.18.1.jar:1.18.1]
at
org.apache.amoro.flink.read.hybrid.enumerator.MixedFormatSourceEnumStateSerializer.serializeV1(MixedFormatSourceEnumStateSerializer.java:95)
~[classes/:?]
at
org.apache.amoro.flink.read.hybrid.enumerator.MixedFormatSourceEnumStateSerializer.serialize(MixedFormatSourceEnumStateSerializer.java:62)
~[classes/:?]
at
org.apache.amoro.flink.read.hybrid.enumerator.MixedFormatSourceEnumStateSerializer.serialize(MixedFormatSourceEnumStateSerializer.java:41)
~[classes/:?]
at
org.apache.flink.runtime.source.coordinator.SourceCoordinator.writeCheckpointBytes(SourceCoordinator.java:525)
~[flink-runtime-1.18.1.jar:1.18.1]
at
org.apache.flink.runtime.source.coordinator.SourceCoordinator.toBytes(SourceCoordinator.java:510)
~[flink-runtime-1.18.1.jar:1.18.1]
at
org.apache.flink.runtime.source.coordinator.SourceCoordinator.lambda$checkpointCoordinator$7(SourceCoordinator.java:384)
~[flink-runtime-1.18.1.jar:1.18.1]
at
org.apache.flink.runtime.source.coordinator.SourceCoordinator.lambda$runInEventLoop$10(SourceCoordinator.java:469)
~[flink-runtime-1.18.1.jar:1.18.1]
at
org.apache.flink.util.ThrowableCatchingRunnable.run(ThrowableCatchingRunnable.java:40)
~[flink-core-1.18.1.jar:1.18.1]
... 7 more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
