klion26 commented on code in PR #3743: URL: https://github.com/apache/amoro/pull/3743#discussion_r2293043703
########## NOTICE-binary: ########## @@ -42,6 +42,42 @@ Copyright 2005-2024 The Apache Software Foundation Apache Commons Lang Copyright 2001-2024 The Apache Software Foundation +Apache Commons Pool Review Comment: IIUC, we don't need to mention the ASF project here? ``` - binary distribution NOTICE should content the NOTICE from ALv2 project (non ASF), for instance Jackson, AWS SDK, Netty, etc. That would be great to double check that for next releases. ``` ########## NOTICE-binary: ########## @@ -42,6 +42,42 @@ Copyright 2005-2024 The Apache Software Foundation Apache Commons Lang Copyright 2001-2024 The Apache Software Foundation +Apache Commons Pool Review Comment: And we can remove the ASF project listed in the `NOTICE` file ``` - NOTICE is OK. Nit: the NOTICE can be lighter: no need to mention the ASF projects here (Iceberg, Paimon, Flink) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
