zhoujinsong commented on code in PR #3743:
URL: https://github.com/apache/amoro/pull/3743#discussion_r2293065296


##########
NOTICE-binary:
##########
@@ -42,6 +42,42 @@ Copyright 2005-2024 The Apache Software Foundation
 Apache Commons Lang
 Copyright 2001-2024 The Apache Software Foundation
 
+Apache Commons Pool

Review Comment:
   Yes, it is fine to exclude the ASF project, but I still prefer to include it 
here like many other projects did:
   
   - https://github.com/apache/gravitino/blob/main/NOTICE.bin
   - https://github.com/apache/spark/blob/master/NOTICE-binary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to