zhoujinsong commented on code in PR #3793:
URL: https://github.com/apache/amoro/pull/3793#discussion_r2419029860


##########
docs/admin-guides/managing-optimizers.md:
##########
@@ -282,9 +282,13 @@ The optimizer group supports the following properties:
 | Property                       | Container type | Required | Default         
                                                                      | 
Description                                                                     
                                                                                
                                                                                
                                                                                
                                                                                
 |
 
|--------------------------------|----------------|----------|---------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | scheduling-policy              | All            | No       | quota           
                                                                      | The 
scheduler group scheduling policy, the default value is `quota`, it will be 
scheduled according to the quota resources configured for each table, the 
larger the table quota is, the more optimizer resources it can take. There is 
also a configuration `balanced` that will balance the scheduling of each table, 
the longer the table has not been optimized, the higher the scheduling priority 
will be. |
-| memory                         | Local          | Yes      | N/A             
                                                                      | The max 
memory of JVM for local optimizer, in MBs.                                      
                                                                                
                                                                                
                                                                                
                                                                         |
 | max-input-file-size-per-thread | All            | No       | 
536870912(512MB)                                                                
      | Max input file size per optimize thread.                                
                                                                                
                                                                                
                                                                                
                                                                                
         |
 | ams-optimizing-uri             | All            | No       | 
thrift://{ams.server-expose-host}:{ams.thrift-server.optimizing-service.binding-port}
 | Table optimizing service endpoint. This is used when the default service 
endpoint is not visitable.                                                      
                                                                                
                                                                                
                                                                                
        |
+| cache-enabled                  | All            | No       | false           
                                                                      | Whether 
enable cache in optimizer.                                                      
                                                                                
                                                                                
                                                                                
                                                                         |

Review Comment:
   I am not sure whether we will add more cache rather than delete files. I 
prefer to use the same property for other caches.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to