zhoujinsong commented on code in PR #3793:
URL: https://github.com/apache/amoro/pull/3793#discussion_r2419034578
##########
docs/admin-guides/managing-optimizers.md:
##########
@@ -351,6 +355,10 @@ The description of the relevant parameters is shown in the
following table:
| -eds | No | Whether extend storage to disk, default false.
|
| -dsp | No | Defines the directory where the storage files are
saved, the default temporary-file directory is specified by the system property
`java.io.tmpdir`. On UNIX systems the default value of this property is
typically "/tmp" or "/var/tmp". |
| -msz | No | Memory storage size limit when extending disk
storage(MB), default 512(MB).
|
+| -ce | No | Whether enable cache in optimizer, default false.
|
+| -cmts | No | Max total size in optimier cache, default 100MB.
|
+| -cmes | No | Max entry size in optimizer cache, default 50MB.
|
Review Comment:
fixed.
##########
amoro-optimizer/amoro-optimizer-common/src/main/java/org/apache/amoro/optimizer/common/OptimizerConfig.java:
##########
@@ -79,6 +79,30 @@ public class OptimizerConfig implements Serializable {
@Option(name = "-id", aliases = "--" + OptimizerProperties.RESOURCE_ID,
usage = "Resource id")
private String resourceId;
+ @Option(
+ name = "-ce",
+ aliases = "--" + OptimizerProperties.OPTIMIZER_CACHE_ENABLED,
+ usage = "Whether enable cache, default false")
+ private boolean cacheEnabled =
OptimizerProperties.OPTIMIZER_CACHE_ENABLED_DEFAULT;
+
+ @Option(
+ name = "-cmts",
+ aliases = "--" + OptimizerProperties.OPTIMIZER_CACHE_MAX_TOTAL_SIZE,
+ usage = "Max total size in cache, default 100MB")
Review Comment:
fixed.
##########
amoro-optimizer/amoro-optimizer-common/src/main/java/org/apache/amoro/optimizer/common/OptimizerConfig.java:
##########
@@ -79,6 +79,30 @@ public class OptimizerConfig implements Serializable {
@Option(name = "-id", aliases = "--" + OptimizerProperties.RESOURCE_ID,
usage = "Resource id")
private String resourceId;
+ @Option(
+ name = "-ce",
+ aliases = "--" + OptimizerProperties.OPTIMIZER_CACHE_ENABLED,
+ usage = "Whether enable cache, default false")
+ private boolean cacheEnabled =
OptimizerProperties.OPTIMIZER_CACHE_ENABLED_DEFAULT;
+
+ @Option(
+ name = "-cmts",
+ aliases = "--" + OptimizerProperties.OPTIMIZER_CACHE_MAX_TOTAL_SIZE,
+ usage = "Max total size in cache, default 100MB")
+ private String cacheMaxTotalSize =
OptimizerProperties.OPTIMIZER_CACHE_MAX_TOTAL_SIZE_DEFAULT;
+
+ @Option(
+ name = "-cmes",
+ aliases = "--" + OptimizerProperties.OPTIMIZER_CACHE_MAX_ENTRY_SIZE,
+ usage = "Max entry size in cache, default 50MB")
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
