Jzjsnow commented on code in PR #3776:
URL: https://github.com/apache/amoro/pull/3776#discussion_r2544779782
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/MixedAndIcebergTableDescriptor.java:
##########
@@ -609,6 +733,11 @@ public List<OptimizingTaskInfo> getOptimizingTaskInfos(
private CloseableIterable<PartitionFileBaseInfo> getTableFilesInternal(
AmoroTable<?> amoroTable, String partition, Integer specId) {
MixedTable mixedTable = getTable(amoroTable);
+ return getTableFilesInternal(mixedTable, partition, specId);
+ }
+
+ private CloseableIterable<PartitionFileBaseInfo> getTableFilesInternal(
Review Comment:
You’re absolutely right. The latest commit moves partition file size MSE
calculation to the evaluation scan phase, eliminating the need for an extra
table scan. We’ll further optimize this with PartitionStatistics in future
Iceberg upgrades to potentially avoid file-by-file traversal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
