turboFei commented on code in PR #3776:
URL: https://github.com/apache/amoro/pull/3776#discussion_r2570073595
##########
amoro-ams/src/main/java/org/apache/amoro/server/scheduler/inline/TableRuntimeRefreshExecutor.java:
##########
@@ -62,6 +63,16 @@ private void tryEvaluatingPendingInput(DefaultTableRuntime
tableRuntime, MixedTa
// only evaluate pending input when optimizing is enabled and in idle state
if (tableRuntime.getTableConfiguration().getOptimizingConfig().isEnabled()
&& tableRuntime.getOptimizingStatus().equals(OptimizingStatus.IDLE)) {
+
+ if
(tableRuntime.getTableConfiguration().getOptimizingConfig().isEventBasedTriggerEnabled()
+ && !MetricBasedEvaluationEvent.isEvaluatingNecessary(
+ tableRuntime.getOptimizingConfig(), table,
tableRuntime.getLastPlanTime())) {
Review Comment:
Can we define variable likes `OptimizingConfig config =
tableRuntime.getOptimizingConfig()` and reuse it to make it clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
