Jzjsnow commented on code in PR #3776:
URL: https://github.com/apache/amoro/pull/3776#discussion_r2602717516
##########
amoro-ams/src/main/java/org/apache/amoro/server/scheduler/inline/TableRuntimeRefreshExecutor.java:
##########
@@ -62,6 +63,16 @@ private void tryEvaluatingPendingInput(DefaultTableRuntime
tableRuntime, MixedTa
// only evaluate pending input when optimizing is enabled and in idle state
if (tableRuntime.getTableConfiguration().getOptimizingConfig().isEnabled()
&& tableRuntime.getOptimizingStatus().equals(OptimizingStatus.IDLE)) {
+
+ if
(tableRuntime.getTableConfiguration().getOptimizingConfig().isEventBasedTriggerEnabled()
+ && !MetricBasedEvaluationEvent.isEvaluatingNecessary(
+ tableRuntime.getOptimizingConfig(), table,
tableRuntime.getLastPlanTime())) {
Review Comment:
> what is the difference between
>
> `tableRuntime.getTableConfiguration().getOptimizingConfig()` and
`tableRuntime.getOptimizingConfig()`, it looks confuse.
This is indeed puzzling. I see that the instances obtained by both methods
are consistent. We may consider optimizing this in the future.
Anyway, an `OptimizingConfig` variable is defined and reused it to improve
code clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
