turboFei commented on code in PR #4013:
URL: https://github.com/apache/amoro/pull/4013#discussion_r2617829712
##########
amoro-format-mixed/amoro-mixed-spark/v3.4/amoro-mixed-spark-3.4/src/main/scala/org/apache/spark/sql/amoro/parser/MixedFormatSqlExtendAstBuilder.scala:
##########
@@ -527,7 +524,7 @@ class MixedFormatSqlExtendAstBuilder()
// Typed return columns.
val schema = createSchema(transformClause.colTypeList)
val replacedSchema =
CharVarcharUtils.replaceCharVarcharWithStringInSchema(schema)
- (DataTypeUtils.toAttributes(replacedSchema), false)
+ (schema.toAttributes, false)
Review Comment:
should be `replacedSchema.toAttributes`?
##########
amoro-format-mixed/amoro-mixed-spark/v3.4/amoro-mixed-spark-runtime-3.4/pom.xml:
##########
@@ -72,12 +72,13 @@
<include>org.apache.zookeeper:zookeeper-jute</include>
<include>org.apache.iceberg:iceberg-core</include>
<include>org.apache.iceberg:iceberg-api</include>
-
<include>org.apache.iceberg:iceberg-spark-3.5_${scala.binary.version}</include>
+
<include>org.apache.iceberg:iceberg-spark-3.4_${scala.binary.version}</include>
<include>org.apache.iceberg:iceberg-common</include>
<include>org.apache.iceberg:iceberg-data</include>
<include>org.apache.iceberg:iceberg-orc</include>
<include>org.apache.iceberg:iceberg-parquet</include>
<include>org.apache.iceberg:iceberg-aws</include>
+
<include>org.apache.iceberg:iceberg-aliyun</include>
Review Comment:
is it necessary for spark-3.5 as well?
##########
amoro-format-mixed/amoro-mixed-spark/v3.4/amoro-mixed-spark-3.4/src/main/scala/org/apache/spark/sql/amoro/parser/MixedFormatSqlExtendAstBuilder.scala:
##########
@@ -596,7 +593,7 @@ class MixedFormatSqlExtendAstBuilder()
selectClause.hints.asScala.foldRight(plan)(withHints)
}
- def visitCommonSelectQueryClausePlan(
+ private def visitCommonSelectQueryClausePlan(
Review Comment:
nit: necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
