turboFei commented on code in PR #4013:
URL: https://github.com/apache/amoro/pull/4013#discussion_r2646418727
##########
amoro-format-mixed/amoro-mixed-spark/v3.4/amoro-mixed-spark-3.4/pom.xml:
##########
@@ -265,20 +265,6 @@
</exclusions>
</dependency>
- <dependency>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- <version>${scala.version}</version>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-compiler</artifactId>
- <version>${scala.version}</version>
- <scope>provided</scope>
- </dependency>
Review Comment:
do not remove the `<scope>provided</scope>` for spark-3.4, please keep it
consistent for spark-3.5, spark-3.4, spark-3.3, and change it in separate PR if
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
