wardlican commented on code in PR #3950:
URL: https://github.com/apache/amoro/pull/3950#discussion_r3009157709
##########
amoro-ams/src/main/resources/mysql/upgrade.sql:
##########
@@ -164,12 +164,13 @@ ADD COLUMN `process_parameters` mediumtext COMMENT 'Table
process parameters';
-- ADD table bucket_assignments for storing assigned info
CREATE TABLE IF NOT EXISTS bucket_assignments (
- cluster_name
VARCHAR(64) NOT NULL COMMENT 'AMS cluster name',
+ cluster_name VARCHAR(64) NOT NULL COMMENT 'AMS cluster name',
node_key VARCHAR(256) NOT NULL COMMENT 'Node key
(host:thriftBindPort)',
server_info_json TEXT NULL COMMENT 'JSON encoded AmsServerInfo',
assignments_json TEXT NULL COMMENT 'JSON array of bucket IDs',
last_update_time BIGINT NOT NULL DEFAULT 0 COMMENT 'Last update
timestamp (ms since epoch)',
+ node_heartbeat_ts BIGINT NOT NULL DEFAULT 0 COMMENT 'Per-node
heartbeat timestamp updated only by the owning node (ms since epoch)',
Review Comment:
Okay, I will separate this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]