xxubai commented on code in PR #3950:
URL: https://github.com/apache/amoro/pull/3950#discussion_r3019520395
##########
amoro-optimizer/amoro-optimizer-common/src/main/java/org/apache/amoro/optimizer/common/OptimizerConfig.java:
##########
@@ -214,6 +220,14 @@ public void setCacheTimeout(String cacheTimeout) {
this.cacheTimeout = cacheTimeout;
}
+ public boolean isMasterSlaveMode() {
+ return masterSlaveMode;
+ }
+
+ public void setMasterSlaveMode(boolean masterSlaveMode) {
+ this.masterSlaveMode = masterSlaveMode;
+ }
+
@Override
public String toString() {
Review Comment:
nit: missing field `masterSlaveMode` in `toString`
##########
amoro-ams/src/main/resources/postgres/upgrade.sql:
##########
@@ -224,12 +224,15 @@ ADD COLUMN process_parameters text;
-- ADD table bucket_assignments for storing assigned info
CREATE TABLE IF NOT EXISTS bucket_assignments (
- cluster_name
VARCHAR(64) NOT NULL,
+ cluster_name VARCHAR(64) NOT NULL,
node_key VARCHAR(256) NOT NULL,
server_info_json TEXT NULL,
assignments_json TEXT NULL,
last_update_time BIGINT NOT NULL DEFAULT 0,
PRIMARY KEY (cluster_name, node_key)
- );
+);
CREATE INDEX IF NOT EXISTS idx_bucket_assignments_cluster ON
bucket_assignments (cluster_name);
+
+-- ADD node_heartbeat_ts to table bucket_assignments
+ALTER TABLE table_process ADD COLUMN node_heartbeat_ts BIGINT NOT NULL DEFAULT
0;
Review Comment:
```suggestion
ALTER TABLE bucket_assignments ADD COLUMN node_heartbeat_ts BIGINT NOT NULL
DEFAULT 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
