lintingbin commented on PR #4206: URL: https://github.com/apache/amoro/pull/4206#issuecomment-4394382931
@czy006 @xxubai CI is green. This is the flink-common piece of #4203 — 53 files + the `AmoroRunListener` migration to a JUnit 5 `TestExecutionListener` (registered via SPI), 14 `@RunWith(Parameterized.class)` classes rewritten. One non-mechanical decision worth your eye is flagged in the PR body: `FlinkTestBase` / `AmoroCatalogITCaseBase` / `CatalogITCaseBase` no longer extend the still-JUnit-4 iceberg/amoro-common bases; the catalog/table lifecycle is reimplemented inline. Happy to refactor to keep the inheritance if you'd prefer — please push back either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
